fix: Fixes issue with patternfly-starter seed is not building.#34
Merged
jpuzz0 merged 2 commits intopatternfly:mainfrom Apr 29, 2026
Merged
fix: Fixes issue with patternfly-starter seed is not building.#34jpuzz0 merged 2 commits intopatternfly:mainfrom
jpuzz0 merged 2 commits intopatternfly:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughUpdated Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
fix: Fixes issue with patternfly-startarter seed not building.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/templates.ts`:
- Around line 22-23: The test failure is caused by the starter template
switching to packageManager: "npm"; update the test in
src/__tests__/create.test.ts that asserts the runtime installer, so that the
assertion for runCreate(projectDir, 'starter') expects execa to be invoked with
'npm' instead of 'yarn' (or alternatively change the test to call a yarn-based
template like 'compass-starter'/'nextjs-starter'); modify the expectation that
inspects execa calls in the “uses template packageManager and runs install” test
to match the new packageManager value for the 'starter' template.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
jpuzz0
approved these changes
Apr 29, 2026
github-project-automation
Bot
moved this from Needs triage
to Done
in PatternFly Issues
|
🎉 This PR is included in version 1.2.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the bug where the PatternFly seed (starter selection when creating a project) does not build. Closes jira issue #4007
Summary by CodeRabbit